Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: fix assertion error #1471

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

hijackthe2
Copy link
Contributor

Fix assertion error by explicitly specifying type when building nydus in macos arm64 environment.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

…ing nydus in macos arm64 environment.

Signed-off-by: hijackthe2 <[email protected]>
@hijackthe2 hijackthe2 requested a review from a team as a code owner November 7, 2023 02:05
@hijackthe2 hijackthe2 requested review from bergwolf, liubin and changweige and removed request for a team November 7, 2023 02:05
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1471 (16545dd) into master (89882a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   54.85%   54.85%   -0.01%     
==========================================
  Files         123      123              
  Lines       40477    40477              
  Branches    40477    40477              
==========================================
- Hits        22205    22204       -1     
- Misses      17033    17034       +1     
  Partials     1239     1239              
Files Coverage Δ
builder/src/stargz.rs 74.67% <100.00%> (ø)

... and 2 files with indirect coverage changes

@jiangliu jiangliu merged commit 002b2f2 into dragonflyoss:master Nov 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants